(maint) Validate Type Schema

[da-ar]

This has been split out and updated from pr #141

[DavidS]

duplicates

puppet-resource_api/lib/puppet/resource_api.rb

Lines 22 to 48 in 3099283

	raise Puppet::DevError, 'requires a hash as definition, not `%{other_type}`' % { other_type: definition.class } unless definition.is_a? Hash
	raise Puppet::DevError, 'requires a `:name`' unless definition.key? :name
	raise Puppet::DevError, 'requires `:attributes`' unless definition.key? :attributes
	raise Puppet::DevError, '`:attributes` must be a hash, not `%{other_type}`' % { other_type: definition[:attributes].class } unless definition[:attributes].is_a?(Hash)
	[:title, :provider, :alias, :audit, :before, :consume, :export, :loglevel, :noop, :notify, :require, :schedule, :stage, :subscribe, :tag].each do |name|
	raise Puppet::DevError, 'must not define an attribute called `%{name}`' % { name: name.inspect } if definition[:attributes].key? name
	end
	if definition.key?(:title_patterns) && !definition[:title_patterns].is_a?(Array)
	raise Puppet::DevError, '`:title_patterns` must be an array, not `%{other_type}`' % { other_type: definition[:title_patterns].class }
	end
	Puppet::ResourceApi::DataTypeHandling.validate_ensure(definition)
	definition[:features] ||= []
	supported_features = %w[supports_noop canonicalize remote_resource simple_get_filter].freeze
	unknown_features = definition[:features] - supported_features
	Puppet.warning("Unknown feature detected: #{unknown_features.inspect}") unless unknown_features.empty?
	# fixup any weird behavior ;-)
	definition[:attributes].each do |name, attr|
	next unless attr[:behavior]
	if attr[:behaviour]
	raise Puppet::DevError, "the '#{name}' attribute has both a `behavior` and a `behaviour`, only use one"
	end
	attr[:behaviour] = attr[:behavior]
	attr.delete(:behavior)
	end

[da-ar]

Still needs the test moved to their new home

[Thomas-Franklin]

Clean refactor 👍