(IAC-858) Add ruby 2.7 and other cleanups #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that codecov 0.1.17 introduced using ruby 2.0.0(!) or later syntax that is breaking on JRuby 1.7 (ruby 1.9 syntax level, still in use in puppetserver). This is not relevant to modules, but had an impact on some of our gems.
DavidS
force-pushed
the
iac-858-add-ruby27
branch
from
af0eb73 to
9cd06ed
Compare
DavidS
force-pushed
the
iac-858-add-ruby27
branch
from
9cd06ed to
5cff2a9
Compare
simplecov is already pulled in by simplecov-console and codecov on the base gem
DavidS
force-pushed
the
iac-858-add-ruby27
branch
from
5cff2a9 to
658e41a
Compare
gemfury is quite limited and the interface is awful to use. cloudsmith on the other hand has a generous OSS offering that is easily workable for us and the interface is much nicer to use, e.g. for batch removal of packages after use.
DavidS
force-pushed
the
iac-858-add-ruby27
branch
3 times, most recently
from
b20e874 to
f05b52e
Compare
the ed25519 and bcrypt_pbkdf are required for ed25519 keys when using bolt, but the ed25519 gem fails building on windows in bolt and pdk native packaging. See https://tickets.puppetlabs.com/browse/BOLT-1296 and puppetlabs/bolt#1337 for details.
DavidS
force-pushed
the
iac-858-add-ruby27
branch
from
f05b52e to
dc7bb5f
Compare
|
closing and re-opening to notify appveyor |
DavidS
force-pushed
the
iac-858-add-ruby27
branch
3 times, most recently
from
f5fd721 to
8a09785
Compare
DavidS
force-pushed
the
iac-858-add-ruby27
branch
from
8a09785 to
21208c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "other cleanups" are splitting out some gems into specific version pins for the different ruby versions so that more recent versions can be used, and removing some redundant pins.
Fixes #127 ; fixes #118