Fix plugin regressions introduced in 3.0.0 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekohl Thank you. I was working on a fix for this last night, you beat me to it! 😃 |
chelnak
suggested changes
Oct 20, 2022
spec/spec_helper.rb
Outdated
| @@ -134,7 +134,7 @@ def subject | |||
| config.include( | |||
| RSpec::LintExampleGroup, | |||
| type: :lint, | |||
| file_path: Regexp.compile(['spec', 'unit', 'puppet-lint', 'plugins'].join('[\\\/]')), | |||
| file_path: Regexp.compile(['spec', 'puppet-lint', 'plugins'].join('[\\\/]')), | |||
There was a problem hiding this comment.
Reverting this actually breaks the spec tests in puppet-lint.
Lets make it more inclusive of both patterns:
Suggested change
| file_path: Regexp.compile(['spec', 'puppet-lint', 'plugins'].join('[\\\/]')), | |
| file_path: Regexp.new('spec[\\\/](unit[\\\/])?puppet-lint[\\\/]plugins'), |
|
@ekohl Have left a couple of suggestions that should get this PR moving. Happy to merge asap. |
ekohl
force-pushed
the
fix-plugin-spec-testing
branch
from
adcc6f7 to
662d189
Compare
ekohl
force-pushed
the
fix-plugin-spec-testing
branch
from
662d189 to
a97f52d
Compare
chelnak
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows plugins to work again. See individual commits for details.
Fixes #65