Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-811) Add Ruby 3.2 support and Remove support for Ruby 2.5 #113

Merged
merged 56 commits into from
Apr 6, 2023
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
bbbbd6e
(CONT-811) Correct initial cops
GSPatton Mar 28, 2023
03ec6ff
(CONT-811) Correct Gemspec/RequireMFA
GSPatton Mar 28, 2023
61c10fe
(CONT-811) Correct Layout/IndentationConsistency
GSPatton Mar 28, 2023
bdf1d46
(CONT-811) Correct Layout/LineContinuationSpacing
GSPatton Mar 28, 2023
cf3edb9
(CONT-811) Correct Performance/StringIdentifierArgument
GSPatton Mar 28, 2023
9f3d8c4
(CONT-811) Correct Performance/StringInclude
GSPatton Mar 28, 2023
1399d01
(CONT-811) Correct RSpec/BeEq
GSPatton Mar 28, 2023
02757e9
(CONT-811) Correct RSpec/ExcessiveDocstringSpacing
GSPatton Mar 28, 2023
184ca8a
(CONT-811) Correct Security/IoMethods
GSPatton Mar 28, 2023
377b350
(CONT-811) disabling Style/ClassAndModuleChildren issues
GSPatton Mar 28, 2023
ac37821
(CONT-811) Correcting Style/EnvHome
GSPatton Mar 28, 2023
fbb2e5f
(CONT-811) Correct Style/FetchEnvVar
GSPatton Mar 28, 2023
24ae532
(CONT-811) Correct Style/RedundantConstantBase
GSPatton Mar 28, 2023
e5b7577
(CONT-811) Correcting Style/RedundantStringEscape
GSPatton Mar 28, 2023
e7912bf
(CONT-811) Correct Style/SafeNavigation
GSPatton Mar 28, 2023
9adc842
(CONT-811) Correct Style/TernaryParentheses
GSPatton Mar 28, 2023
2a292f6
(CONT-811) Updating rubocop and associated gems versions
GSPatton Mar 28, 2023
c8d98ef
(CONT-811) Adding ruby 3.2 to workflow test matrices
GSPatton Mar 29, 2023
1c19e5e
(CONT-811) Enabling all cops. Removing all unconfigured cops. Includi…
GSPatton Mar 29, 2023
2111c6d
(CONT-811) Adding rubocop_todo
GSPatton Mar 29, 2023
8de3c98
(CONT-811) Dropping Ruby 2.5 from tests as Puppet 6 will not be suppo…
GSPatton Mar 29, 2023
8a90792
(CONT-811) Raising minimum required ruby version in gemspec
GSPatton Mar 29, 2023
d39a1d0
(CONT-811) Correct Layout/EmptyLineAfterGuardClause
GSPatton Mar 29, 2023
5fe25d1
(CONT-811) Correct Layout/HashAlignment
GSPatton Mar 29, 2023
efd1526
(CONT-811) Correct Lint/ConstantDefinitionInBlock
GSPatton Mar 30, 2023
823b654
(CONT-811) Correct Lint/NonDeterministicRequireOrder
GSPatton Apr 3, 2023
8925d84
(CONT-811) Correct Lint/RedundantRequireStatement
GSPatton Apr 3, 2023
d96c164
(CONT-811) Correct Performance/BindCall
GSPatton Apr 3, 2023
65f6bfd
(CONT-811) Correct Performance/DeletePrefix
GSPatton Apr 3, 2023
13de8bb
(CONT-811) Correct RSpec/ContextMethod
GSPatton Apr 3, 2023
d23da53
(CONT-811) Correct RSpec/EmptyLineAfterExample
GSPatton Apr 3, 2023
b660434
(CONT-811) Correct RSpec/EmptyLineAfterExampleGroup
GSPatton Apr 3, 2023
034715a
(CONT-811) Correct RSpec/ImplicitSubject
GSPatton Apr 3, 2023
92c35b9
(CONT-811) Correct NamedSubject
GSPatton Apr 3, 2023
5e11a79
(CONT-811) Correct RSpec/MultipleSubjects
GSPatton Apr 3, 2023
5e59789
(CONT-811) Correct RSpec/PredicateMatcher
GSPatton Apr 3, 2023
085adb6
(CONT-811) Correct Style/AccessorGrouping
GSPatton Apr 3, 2023
95ef207
(CONT-811) Correct Style/CaseLikeIf
GSPatton Apr 3, 2023
23be6dd
(CONT-811) Correct Style/Encoding
GSPatton Apr 3, 2023
4a541e6
(CONT-811) Correct Style/ExpandPathArguments
GSPatton Apr 3, 2023
27d02ae
(CONT-811) Correct Style/ExplicitBlockArgument
GSPatton Apr 3, 2023
06e66c5
(CONT-811) Correct Style/HashAsLastArrayItem
GSPatton Apr 3, 2023
662d0ab
(CONT-811) Correct Style/IfUnlessModifier
GSPatton Apr 3, 2023
42b2805
(CONT-811) Correct Style/NumericPredicate
GSPatton Apr 3, 2023
69f3071
(CONT-811) Correct Style/RedundantArgument
GSPatton Apr 3, 2023
826d33a
(CONT-811) Correct Style/RedundantRegexpEscape
GSPatton Apr 3, 2023
2b071f0
(CONT-811) Correct Style/RescueStandardError
GSPatton Apr 3, 2023
47f4258
(CONT-811) Correct Style/SlicingWithRange
GSPatton Apr 3, 2023
fc8dae6
(CONT-811) Correct Style/SoleNestedConditional
GSPatton Apr 3, 2023
3c74505
(CONT-811) Correct Style/StderrPuts
GSPatton Apr 3, 2023
96e4122
(CONT-811) Correct Style/TrailingCommaInHashLiteral
GSPatton Apr 3, 2023
fec1244
(CONT-811) Correct Style/UnpackFirst
GSPatton Apr 3, 2023
a3a0a10
(CONT-811) Adding rubocop_todo as this module is under rewrite
GSPatton Apr 3, 2023
b5209a6
(CONT-811) Removing addition of rubygems_mfa requirement in gemspec -…
GSPatton Apr 3, 2023
28559cf
(CONT-811) removing redundant check for HOME env variable as this is …
GSPatton Apr 3, 2023
95d7dff
(CONT-811) Regenerated rubocop_todo to account for removal of Gemspec…
GSPatton Apr 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
(CONT-811) Correct RSpec/EmptyLineAfterExampleGroup
GSPatton committed Apr 6, 2023
commit b66043478ec24ab28f0076105b648af389d3fb2a
10 changes: 10 additions & 0 deletions spec/unit/puppet-lint/plugins/legacy_facts/legacy_facts_spec.rb
Original file line number Diff line number Diff line change
@@ -339,6 +339,7 @@
expect(manifest).to eq("\"$facts['os']['family']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::gid"' do
let(:code) { '"$::gid"' }

@@ -350,6 +351,7 @@
expect(manifest).to eq("\"$facts['identity']['group']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::id"' do
let(:code) { '"$::id"' }

@@ -361,6 +363,7 @@
expect(manifest).to eq("\"$facts['identity']['user']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::lsbdistcodename"' do
let(:code) { '"$::lsbdistcodename"' }

@@ -372,6 +375,7 @@
expect(manifest).to eq("\"$facts['os']['distro']['codename']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::lsbdistdescription"' do
let(:code) { '"$::lsbdistdescription"' }

@@ -383,6 +387,7 @@
expect(manifest).to eq("\"$facts['os']['distro']['description']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::lsbdistid"' do
let(:code) { '"$::lsbdistid"' }

@@ -394,6 +399,7 @@
expect(manifest).to eq("\"$facts['os']['distro']['id']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::lsbdistrelease"' do
let(:code) { '"$::lsbdistrelease"' }

@@ -405,6 +411,7 @@
expect(manifest).to eq("\"$facts['os']['distro']['release']['full']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::lsbmajdistrelease"' do
let(:code) { '"$::lsbmajdistrelease"' }

@@ -416,6 +423,7 @@
expect(manifest).to eq("\"$facts['os']['distro']['release']['major']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::lsbminordistrelease"' do
let(:code) { '"$::lsbminordistrelease"' }

@@ -427,6 +435,7 @@
expect(manifest).to eq("\"$facts['os']['distro']['release']['minor']\"")
end
end

context 'fact variable using legacy variable in double quotes "$::lsbrelease"' do
let(:code) { '"$::lsbrelease"' }

@@ -438,6 +447,7 @@
expect(manifest).to eq("\"$facts['os']['distro']['release']['specification']\"")
end
end

context "fact variable using facts hash in double quotes \"$facts['lsbrelease']\"" do
let(:code) { "\"${facts['lsbrelease']}\"" }

Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@
expect(problems).to have(0).problem
end
end

context 'non-fact variable with two colons' do
let(:code) { '$foo::bar' }