(CAT-2056) - add puppet-blacksmith to templates #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we removed the build rake tasks from puppetlabs_spec_helper v8, we now pull them into spec_helper through a soft dependency on puppet-blacksmith. As such, we should add the puppet-blacksmith gem so that users can still avail of rake tasks like module:build.
danadoherty639
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Module build rake tasks are scheduled for removal in
puppetlabs_spec_helper v8.puppet-blacksmithoffers a range of rake tasks, and was already included inpuppetlabs_spec_helperas a soft dependency, so we should avail of these instead of producing duplicate logic and rake tasks.This adds the puppet-blacksmith gem to the pdk-templates, and bumps puppetlabs_spec_helper to v8.
Additional Context
puppetlabs/puppetlabs_spec_helper#472
Related Issues (if any)
Mention any related issues or pull requests.
Checklist