(FACT-2806) Fix os.release.minor on amazon 6 #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to remove leading 0 for minor versions on rhel
|
Jenkins please test this on all |
gimmyxd
reviewed
Oct 12, 2020
| @@ -27,7 +27,7 @@ def determine_release_version | |||
| fact_value = {} | |||
| fact_value['full'] = version | |||
| fact_value['major'] = versions[0] | |||
| fact_value['minor'] = versions[1].gsub(/^0([1-9])/, '\1') if versions[1] | |||
| fact_value['minor'] = versions[1] if versions[1] | |||
There was a problem hiding this comment.
Is there any test for the scenario that this change is fixing?
There was a problem hiding this comment.
no. from what we can tell at this moment, this code was copy-pasted from the debian os.release fact when the rhel fact was first written. it was not suppose to be there in the first place and it appears to be affecting only amazon 6.
|
CLA signed by all contributors. |
Filipovici-Andrei
approved these changes
Oct 13, 2020
Filipovici-Andrei
pushed a commit
to Filipovici-Andrei/facter
that referenced
this pull request
Oct 15, 2020
We don't need to remove leading 0 for minor versions on rhel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to remove leading 0 for minor versions on rhel.