Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix virtual_detector #2128

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

BogdanIrimie
Copy link
Contributor

When we detect Amazon as vendor using dmidecode we can conclude that the hypervisor is kvm because when it is xen, the vendor is Xen

As the virtual_detector is used in virtual fact, we should return the hypervisor instead of the cloud provider.

@BogdanIrimie BogdanIrimie added the bug Something isn't working label Oct 8, 2020
@BogdanIrimie BogdanIrimie requested review from a team October 8, 2020 12:14
@BogdanIrimie
Copy link
Contributor Author

Jenkins please test this on all

lib/facter/version.rb Outdated Show resolved Hide resolved
@puppetcla
Copy link

CLA signed by all contributors.

@BogdanIrimie
Copy link
Contributor Author

Jenkins please test this on all

@BogdanIrimie BogdanIrimie merged commit 81a83ae into puppetlabs:main Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants