Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-2824) Facter make ec2 metadata requests when on gce #2113

Merged
merged 8 commits into from
Oct 1, 2020

Conversation

BogdanIrimie
Copy link
Contributor

ec2_metadata fact tries to determine on what hypervisor or on what cloud provider it is running on. If it detecters aws, it will call the ec2 fact.

Problem:

  • ec2_metadata fact calls the ec2 resolver when it detects kvm hypervisor, but there are other providers that use kvm, one example is gce.

Solution:

  • improve the detection of hypervisor or cloud provider by adding the logic from virtual and dmi decoder

@BogdanIrimie BogdanIrimie requested review from a team October 1, 2020 10:55
@puppetcla
Copy link

CLA signed by all contributors.

@BogdanIrimie
Copy link
Contributor Author

Jenkins please test this on all

@mihaibuzgau mihaibuzgau merged commit 41899cc into puppetlabs:main Oct 1, 2020
@BogdanIrimie BogdanIrimie added the bug Something isn't working label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants