(FACT-2786) Fix fact caching if fact is defined in multiple groups #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florindragos
force-pushed
the
FACT-2786
branch
2 times, most recently
from
bfbe1cf
to
8128105
Compare
|
CLA signed by all contributors. |
florindragos
force-pushed
the
FACT-2786
branch
4 times, most recently
from
0faa16c
to
30492e8
Compare
|
Jenkins please test this on all |
gimmyxd
reviewed
Sep 18, 2020
|
Jenkins please test this on all |
florindragos
force-pushed
the
FACT-2786
branch
from
30492e8
to
d4cbf4b
Compare
|
Jenkins please test this on all |
florindragos
force-pushed
the
FACT-2786
branch
2 times, most recently
from
c8b9201
to
95e6eb2
Compare
|
Jenkins please test this on all |
florindragos
force-pushed
the
FACT-2786
branch
7 times, most recently
from
1ff2c16
to
db81115
Compare
acceptance/tests/options/config_file/ttls_cahed_individual_fact_name.rb
Outdated
Show resolved
Hide resolved
|
Is there a unit test that checks if a fact contained in two groups is not cached twice? |
florindragos
force-pushed
the
FACT-2786
branch
from
db81115
to
d932b48
Compare
florindragos
force-pushed
the
FACT-2786
branch
from
d932b48
to
fa3f0f4
Compare
too complex for a unit test. added acceptance test. |
Filipovici-Andrei
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also enables fact caching by only specifying individual facts in ttls configuration, rather than needing a cache group.