Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-2708) Add man pages #1984

Merged
merged 1 commit into from
Jul 22, 2020
Merged

(FACT-2708) Add man pages #1984

merged 1 commit into from
Jul 22, 2020

Conversation

florindragos
Copy link
Contributor

No description provided.

@florindragos florindragos requested review from a team July 21, 2020 10:23
lib/facter/framework/cli/cli.rb Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@florindragos florindragos force-pushed the FACT-2708 branch 4 times, most recently from 3682952 to 1db9b93 Compare July 21, 2020 11:10
@puppetcla
Copy link

Waiting for CLA signature by @florindragos

@florindragos - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@oanatmaria oanatmaria added the enhancement New feature or enhancement label Jul 21, 2020
@florindragos florindragos force-pushed the FACT-2708 branch 3 times, most recently from d3b54b3 to 38a6943 Compare July 22, 2020 09:47
@puppetcla
Copy link

CLA signed by all contributors.


abort('Ronn does not appear to be installed') unless File.executable?(ronn)

`mkdir -p ./man/man8`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use ruby code to create directories.

@BogdanIrimie BogdanIrimie merged commit e877d71 into 4.x Jul 22, 2020
@oanatmaria oanatmaria deleted the FACT-2708 branch July 29, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants