This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2475) Fix os.release on Debian #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oanatmaria
commented
Mar 25, 2020
oanatmaria
commented
- Read release fact from /etc/debian_version when os is Debian and from /etc/os-release otherwise instead of lsb_release
- Fix os.release on Debian 10
florindragos
previously approved these changes
Mar 26, 2020
lib/resolvers/os_release_resolver.rb
Outdated
| @@ -39,6 +39,7 @@ def read_os_release_file(fact_name) | |||
|
|
|||
| fill_fact_list(pairs) | |||
| process_name | |||
| find_debian_release if @fact_list[:name] =~ /Debian/ | |||
There was a problem hiding this comment.
I would create a new resolver for Debian. For example OsRelease has the fallowing alternatives RedHatRelease, SuseRelease. We should create something similar for Debian.
BogdanIrimie
approved these changes
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.