Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BKR-496) Move create_tmpdir_on from beaker #56

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Conversation

Dakta
Copy link
Contributor

@Dakta Dakta commented Jul 25, 2018

Also moves spec and acceptance tests. Corresponds to voxpupuli/beaker#1531 Note that this moves the fixed and improved version; wrote it, might as well keep it.

Moved to beaker-puppet because the only invocation was already here:

create_tmpdir_on(host, name, user)

Also moves spec and acceptance tests.
@Dakta
Copy link
Contributor Author

Dakta commented Jul 26, 2018

Tested against puppetlabs/beaker head at 6fa2744a5dec68b694657aab86f4884e7e21bd6b

Spec Tests:

...................................................................................................................................


......................................................................................................................................................

Finished in 1.99 seconds (files took 1.33 seconds to load)
281 examples, 0 failures

Acceptance Tests (Git):

      Test Suite: tests @ 2018-07-26 11:21:42 -0700

      - Host Configuration Summary -


              - Test Case Summary for suite 'tests' -
       Total Suite Time: 43.19 seconds
      Average Test Time: 7.20 seconds
              Attempted: 6
                 Passed: 5
                 Failed: 0
                Errored: 1
                Skipped: 0
                Pending: 0
                  Total: 6

      - Specific Test Case Status -

Failed Tests Cases:
Errored Tests Cases:
  Test Case acceptance/tests/web_helpers_test.rb reported: #<RuntimeError: Failed to fetch_remote_dir 'http://ihn494f35775ikp.delivery.puppetlabs.net//test_dir.keJsoM/' (exit code pid 88668 exit 127)>
    Test line: acceptance/tests/web_helpers_test.rb:37:in `block (3 levels) in run_test'
Skipped Tests Cases:
Pending Tests Cases:
^C

Tests hang after Pending, during XML generation phase. Not considering related, since it did this before I started work.

Not sure why web_helpers_test.rb is in here, since web_helpers.rb is still back in beaker. Also not considering this failure related, since it was failing before I started work.

Previously required a beaker acceptance test resource, which is not available in beaker-puppet acceptance tests and was not actually used.
@kevpl kevpl merged commit 4ca0ad5 into puppetlabs:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants