Use puppet-agent specific helper when installing the MSI #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of commit 5a9c90f. When installing puppet-agent packages we need to use the install_msi_on helper, because it sets the service startup type to manual, which prevents the service from starting and sending a CSR before we've configured the agent. It also verifies that the service startup is correct after installation, otherwise you can get transient failures if the background agent service is running while performing puppet agent -t runs in the foreground. When installing MSI packages for other projects, use the generic_install_msi_on method.
When the master host also has an agent role, we don't want to manually run `puppet agent -t`, because puppetserver will generate the self-signed CA and server certs when it starts. Rather than checking for the role, enumerate the agents, skipping the agent if it is also the master host. Add a comment about why we're deleting the contents of the ssldir instead of the directory.
joshcooper
force-pushed
the
windows-puppet-agent-msi
branch
from
e4ce137
to
41f12a0
Compare
|
I ended up not being able to make larger changes because we need to make sure the master's cert has the required dns alt names. |
|
/cc @MikaelSmith @ekinanp |
MikaelSmith
approved these changes
Apr 26, 2018
|
Do you want me to cut a new beaker-puppet release now, or wait? |
|
Please do @melissa! That should resolve the windows CI failures we're seeing in puppet-agent#5.5.x and master. |
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of commit 5a9c90f. When installing
puppet-agent packages we need to use the install_msi_on helper, because
it sets the service startup type to manual, which prevents the service
from starting and sending a CSR before we've configured the agent. It
also verifies that the service startup is correct after installation,
otherwise you can get transient failures if the background agent service
is running while performing puppet agent -t runs in the foreground.
When installing MSI packages for other projects, use the
generic_install_msi_on method.