Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported network platforms #254

Merged
merged 1 commit into from
May 28, 2024

Conversation

mhashizume
Copy link
Contributor

This needs testing but I'd like to get this in before the next major release of beaker-puppet.

@joshcooper
Copy link
Contributor

joshcooper commented May 28, 2024

The tests are failing on this call to File.read

if host['platform'].variant =~ /^(ubuntu|debian)$/
# Bypass signing checks on this repo and its packages
original_contents = File.read(repo)

This seems to fix it

--- a/spec/beaker-puppet/install_utils/foss_utils_spec.rb
+++ b/spec/beaker-puppet/install_utils/foss_utils_spec.rb
@@ -864,6 +864,8 @@ describe ClassMixedWithDSLInstallUtils do
         allow(rez).to receive(:exit_code) { 0 }
         allow(subject).to receive(:link_exists?).and_return(true)
         expect(subject).to receive(:scp_to).with(host, repo_config, /.*/).ordered
+        allow(File).to receive(:read).and_call_original
+        allow(File).to receive(:read).with(repoconfig).and_return('')
         subject.install_puppetlabs_dev_repo host, package_name, package_version
       end
     end

@mhashizume mhashizume marked this pull request as ready for review May 28, 2024 17:42
@mhashizume mhashizume requested a review from a team as a code owner May 28, 2024 17:42
@joshcooper joshcooper merged commit 9dbca23 into puppetlabs:main May 28, 2024
6 checks passed
@mhashizume mhashizume deleted the network-os-removal branch May 28, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants