Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update excluded label to "maintenance" #247

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

mhashizume
Copy link
Contributor

Previously, this project used the "skip-changelog" label on PRs to denote PRs that were trivial enough to not include in changelog generation.

However, the auto_release_prep workflow that we use to generate changelogs makes the assumption that the caller repository uses a "maintenance" label. The workflow errors if the caller repository does not use that label.

I have renamed the "skip-changelog" label to "maintenance" to account for this discrepancy between this project and the release prep workflow.

This commit updates the GitHub changelog generator configuration file to exclude the "maintenance" label instead of "skip-changelog."

Previously, this project used the "skip-changelog" label on PRs to
denote PRs that were trivial enough to not include in changelog
generation.

However, the auto_release_prep workflow that we use to generate
changelogs makes the assumption that the caller repository uses a
"maintenance" label. The workflow errors if the caller repository does
not use that label.

I have renamed the "skip-changelog" label to "maintenance" to account
for this discrepancy between this project and the release prep workflow.

This commit updates the GitHub changelog generator configuration file to
exclude the "maintenance" label instead of "skip-changelog."
@mhashizume mhashizume requested a review from a team as a code owner February 14, 2024 20:34
@tvpartytonight tvpartytonight merged commit 057cd9f into puppetlabs:main Feb 14, 2024
6 checks passed
@mhashizume mhashizume deleted the maint/main/exclude-label branch February 14, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants