Beaker 5 compatibility #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert_no_match method in Beaker was long deprecated then eventually removed altogether in voxpupuli/beaker@6282311 This commit updates assert_no_match to refute_match.
mhashizume
force-pushed
the
PA-5782/master/drop-beaker-4
branch
from
ea47677
to
e09cb56
Compare
mhashizume
force-pushed
the
PA-5782/master/drop-beaker-4
branch
3 times, most recently
from
f475ddd
to
014d5a8
Compare
Passenger support was dropped in Puppet 6 and support for passenger-related methods was removed from Beaker in voxpupuli/beaker@74047d1. This commit removes all passenger-related Beaker methods. The start_puppet_from_source_on! method is unused as a result of this removal. Additionally, since this method's purpose was to control the WEBrick-based server that was removed from Puppet in Puppet 6 (see puppetlabs/puppet@9275e62), I've also removed the start_puppet_from_source_on! method. Co-authored-by: Tim Meusel <[email protected]>
Beaker removed all install_puppet_agent_* method in voxpupuli/beaker@cdaedad. This commit removes beaker-puppet methods that relied on those install_puppet_agent_* methods. Co-authored-by: Tim Meusel <[email protected]>
Beaker 5.0.0 was released in March 2023 and all development effort is now focused on that stream. This commit updates beaker-puppet to require at least Beaker 5.0.
Ruby 3.2 removed Object#taint and #tainted?. One of beaker-puppet's depenencies, inifile, uses those methods. This commit updates the gemspec to limit usage on Ruby 3.2 and above. Also see: puppetlabs#206
This commit removes the deprecated get_puppet_collection method.
mhashizume
force-pushed
the
PA-5782/master/drop-beaker-4
branch
from
014d5a8
to
56133a8
Compare
|
Passing ad hoc agent pipeline with Beaker 5: https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/ad-hoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/1291/ |
|
I want to repeat what I'm saying since 2017: |
cthorn42
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Beaker 5 compatibility by dropping Beaker 4-specific code and updating the gemspec.
This PR supercedes #216