(maint) Refactor puppet5 install logic #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the "install_from_build_data_url" method was trying to install the artifact as a cygwin package which won't work for MSIs. Instead use the beaker method for installing as an MSI. Note the "install_msi_on" method is specific to the puppet-agent package, because it will ensure the puppet service is stopped before installing and will install it as a Manual service. In the future we may want to differentiate between the puppet-agent project and others, and use "generic_install_msi_on" for the latter.
Add a test for EOS.
Previously the if/elsif block set onhost_package_file for some, but not all hosts. Then a second if/elsif block called different install methods based on the platform variant and the above variable. This commit uses a single case/when statement to branch. It makes it clearer that EOS calls install_from_file, OSX uses the single argument version of install_local_package, while Solaris uses the two argument version. Also Windows uses a different installation method entirely.
|
Can one of the admins verify this patch? |
melissa
approved these changes
Jan 5, 2018
|
👍 will kick testing once #23 is merged, then we should be good to merge & release |
|
@puppetlabs-jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked on #23
Previously the if/elsif block set onhost_package_file for some, but not
all hosts. Then a second if/elsif block called different install methods
based on the platform variant and the above variable.
This commit uses a single case/when statement to branch. It makes it
clearer that EOS calls install_from_file, OSX uses the single argument
version of install_local_package, while Solaris uses the two argument
version. Also Windows uses a different installation method entirely.