Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon linux 2023 platform support #228

Merged

Conversation

span786
Copy link
Contributor

@span786 span786 commented Dec 19, 2023

Added platform support for Amazon Linux 2023

This change is done as part of [PE-37297] (This is internal to Puppet Team)

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c979ea2) 78.87% compared to head (6063d22) 78.87%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files          15       15           
  Lines        1567     1567           
=======================================
  Hits         1236     1236           
  Misses        331      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bastelfreak bastelfreak changed the title [PE-37297]: Added Amazon lInux 2023 platform support [PE-37297]: Add Amazon lInux 2023 platform support Dec 19, 2023
@bastelfreak bastelfreak changed the title [PE-37297]: Add Amazon lInux 2023 platform support [PE-37297]: Add Amazon linux 2023 platform support Dec 19, 2023
@bastelfreak
Copy link
Contributor

I will fix the rubocop issues in another PR. Would it be possible that you move the PE ticket to another project? It's not visible for non-employees and that makes it a bit annoying when a commit references it.

@bastelfreak
Copy link
Contributor

#230 rubocop fix

@span786 span786 changed the title [PE-37297]: Add Amazon linux 2023 platform support Add Amazon linux 2023 platform support Dec 19, 2023
@span786
Copy link
Contributor Author

span786 commented Dec 19, 2023

@bastelfreak
I have removed the mention of Ticket from PR's subject and added it in the description so that we can keep track of it.

@mhashizume
Copy link
Contributor

Closing and reopening PR for checks now that #230 has been merged

@mhashizume mhashizume closed this Dec 20, 2023
@mhashizume mhashizume reopened this Dec 20, 2023
@mhashizume mhashizume merged commit fcf06b4 into puppetlabs:master Dec 20, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants