Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RuboCop #212

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Implement RuboCop #212

merged 1 commit into from
Mar 28, 2023

Conversation

bastelfreak
Copy link
Contributor

No description provided.

@bastelfreak bastelfreak requested a review from ekohl March 11, 2023 04:28
@codecov
Copy link

codecov bot commented Mar 11, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (bbc210b) 78.19% compared to head (fe86ed5) 78.19%.

❗ Current head fe86ed5 differs from pull request most recent head a2be809. Consider uploading reports for the commit a2be809 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files          15       15           
  Lines        1605     1605           
=======================================
  Hits         1255     1255           
  Misses        350      350

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ekohl
ekohl suggested changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we start with disabling all Layout, Metrics and Style cops?

@bastelfreak
Copy link
Contributor Author

@ekohl done

@bastelfreak bastelfreak self-assigned this Mar 11, 2023
@bastelfreak
Copy link
Contributor Author

@ekohl can you please take a look again?

@bastelfreak bastelfreak merged commit 4dc270f into puppetlabs:master Mar 28, 2023
@bastelfreak bastelfreak deleted the dependabot branch March 28, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @ekohl