Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure defaults on FreeBSD #210

Merged
merged 1 commit into from
Feb 28, 2023
Merged

configure defaults on FreeBSD #210

merged 1 commit into from
Feb 28, 2023

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Feb 28, 2023

without this the data from foss_defaults is not properly loaded, leading to errors like:

Beaker::Host::CommandFailure:
  Host 'freebsd12-64-1' exited with 64 running:
   mkdir -p
  Last 100 lines of output were:
  	usage: mkdir [-pv] [-m mode] directory_name ...

# ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/host.rb:396:in `exec'
# ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/host/unix/exec.rb:152:in `mkdir_p'
# ./vendor/bundle/ruby/3.1.0/bundler/gems/beaker-puppet-c27c768fb186/lib/beaker-puppet/install_utils/foss_utils.rb:341:in `block in install_puppet_on'
# ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/shared/host_manager.rb:129:in `run_block_on'
# ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/dsl/patterns.rb:37:in `block_on'
# ./vendor/bundle/ruby/3.1.0/bundler/gems/beaker-puppet-c27c768fb186/lib/beaker-puppet/install_utils/foss_utils.rb:306:in `install_puppet_on'
# ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:49:in `block in run_puppet_install_helper_on'
# ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:43:in `each'
# ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:43:in `run_puppet_install_helper_on'
# ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:8:in `run_puppet_install_helper'
# ./vendor/bundle/ruby/3.1.0/gems/voxpupuli-acceptance-1.2.0/lib/voxpupuli/acceptance/spec_helper_acceptance.rb:24:in `configure_beaker'
# ./spec/spec_helper_acceptance.rb:7:in `<top (required)>'
# ./spec/acceptance/mosquitto_spec.rb:3:in `require'
# ./spec/acceptance/mosquitto_spec.rb:3:in `<top (required)>'

without this the data from foss_defaults is not properly loaded, leading
to errors like:

    Beaker::Host::CommandFailure:
      Host 'freebsd12-64-1' exited with 64 running:
       mkdir -p
      Last 100 lines of output were:
      	usage: mkdir [-pv] [-m mode] directory_name ...

    # ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/host.rb:396:in `exec'
    # ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/host/unix/exec.rb:152:in `mkdir_p'
    # ./vendor/bundle/ruby/3.1.0/bundler/gems/beaker-puppet-c27c768fb186/lib/beaker-puppet/install_utils/foss_utils.rb:341:in `block in install_puppet_on'
    # ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/shared/host_manager.rb:129:in `run_block_on'
    # ./vendor/bundle/ruby/3.1.0/gems/beaker-4.39.0/lib/beaker/dsl/patterns.rb:37:in `block_on'
    # ./vendor/bundle/ruby/3.1.0/bundler/gems/beaker-puppet-c27c768fb186/lib/beaker-puppet/install_utils/foss_utils.rb:306:in `install_puppet_on'
    # ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:49:in `block in run_puppet_install_helper_on'
    # ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:43:in `each'
    # ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:43:in `run_puppet_install_helper_on'
    # ./vendor/bundle/ruby/3.1.0/gems/beaker-puppet_install_helper-0.9.8/lib/beaker/puppet_install_helper.rb:8:in `run_puppet_install_helper'
    # ./vendor/bundle/ruby/3.1.0/gems/voxpupuli-acceptance-1.2.0/lib/voxpupuli/acceptance/spec_helper_acceptance.rb:24:in `configure_beaker'
    # ./spec/spec_helper_acceptance.rb:7:in `<top (required)>'
    # ./spec/acceptance/mosquitto_spec.rb:3:in `require'
    # ./spec/acceptance/mosquitto_spec.rb:3:in `<top (required)>'
@evgeni
Copy link
Contributor Author

evgeni commented Feb 28, 2023

With this patch, I can run PUPPET_INSTALL_TYPE=foss BEAKER_setfile=freebsd12-64 BEAKER_HYPERVISOR=vagrant_libvirt bundle exec rake beaker on puppet-mosquitto without any issues.

Not setting PUPPET_INSTALL_TYPE leads to AIO being assumed, and that obviously fails as there is no AIO on FreeBSD.

cc @smortex

@ekohl ekohl merged commit 078f66e into puppetlabs:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants