Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Always set the platform as a Beaker::Platform instance #209

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Feb 27, 2023

In Beaker 4.39.0 it uses the platform.variant method. Previously it stubbed .to_array, but that is no longer sufficient. This changes the tests to use an actual Beaker::Platform instance rather than a mock Object.

Fixes voxpupuli/beaker#1772

In Beaker 4.39.0 it uses the platform.variant method. Previously it
stubbed .to_array, but that is no longer sufficient. This changes the
tests to use an actual Beaker::Platform instance rather than a mock
Object.
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 78.19% // Head: 78.19% // No change to project coverage 👍

Coverage data is based on head (656b92a) compared to base (94be176).
Patch coverage: 71.42% of modified lines in pull request are covered.

❗ Current head 656b92a differs from pull request most recent head 708ad54. Consider uploading reports for the commit 708ad54 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files          15       15           
  Lines        1605     1605           
=======================================
  Hits         1255     1255           
  Misses        350      350           
Impacted Files Coverage Δ
lib/beaker-puppet/helpers/puppet_helpers.rb 86.49% <0.00%> (ø)
lib/beaker-puppet/install_utils/foss_utils.rb 70.12% <83.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evgeni evgeni merged commit e7aaed4 into puppetlabs:master Feb 27, 2023
@ekohl ekohl deleted the fix-tests branch February 27, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.39.0 breaks beaker-puppet tests
3 participants