-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.29.0 #203
Release 1.29.0 #203
Conversation
Codecov ReportBase: 78.19% // Head: 78.19% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 78.19% 78.19%
=======================================
Files 15 15
Lines 1605 1605
=======================================
Hits 1255 1255
Misses 350 350 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, otherwise 👍
CHANGELOG.md
Outdated
@@ -10,6 +26,10 @@ All notable changes to this project will be documented in this file. | |||
|
|||
- \(PA-4552\) Create ci:test:setup step for iterative workflow [\#194](https://github.com/voxpupuli/beaker-puppet/pull/194) ([joshcooper](https://github.com/joshcooper)) | |||
|
|||
**Merged pull requests:** | |||
|
|||
- Release 1.28.0 [\#201](https://github.com/voxpupuli/beaker-puppet/pull/201) ([joshcooper](https://github.com/joshcooper)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally we skip these. I've added the skip-changelog label now so it should be gone if you regenerate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm it seems that running bundle exec rake changelog
didn't change anything, so I added a github changelog generator file to ignore that label if you think that's appropriate? (After rerunning the task it removed the lines you mentioned)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the changelog generator caches in /tmp/something. We exclude the label in the Rakefile:
config.exclude_labels = %w{duplicate question invalid wontfix wont-fix skip-changelog}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, weird not sure why it still picking up that PR earlier then ¯_(ツ)_/¯
aff44f3
to
a620634
Compare
a620634
to
3ba2591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.