-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Follow redirects when curling MSI #176
Conversation
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 77.77% 77.77%
=======================================
Files 15 15
Lines 1602 1602
=======================================
Hits 1246 1246
Misses 356 356
Continue to review full report at Codecov.
|
|
Add `--location` curl option, otherwise we save the redirect HTML page as the msi, try to install that, and of course msiexec fails with 1620 since the package is invalid.
bf6c4d2
to
2631e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the logic in #173 maybe we can switch to long options here too?
Co-authored-by: Romain Tartière <[email protected]>
3e3f3c9
to
32ad322
Compare
@joshcooper thanks for the PR. we try to provide those from forks to reduce the amount of direct commits into the vox pupuli reason. please do that in the future if possible. |
Add
--location
curl option, otherwise we save the redirect HTML page as themsi, try to install that, and of course msiexec fails with 1620 since the
package is invalid.