Update specs to fix ruby 3 spec failures #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3 changed the way positional and keyword arguments work. In order to get specs to pass when we pass in a hash we need to use braces. This PR addresses that.
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 78.07% 78.07%
=======================================
Files 15 15
Lines 1596 1596
=======================================
Hits 1246 1246
Misses 350 350 Continue to review full report at Codecov.
|
|
This will fix the failures we're seeing on #173. |
joshcooper
approved these changes
Feb 18, 2022
cthorn42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3 changed the way positional and keyword arguments work. In order
to get specs to pass when we pass in a hash we need to use braces. This PR
addresses that.