Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Enable Windows hosts to use the package_proxy #133

Conversation

markcassidy
Copy link
Contributor

There does not appear to be any support to enable the installation of a Windows package via the :package_proxy setting. This contribution would add that support.

@markcassidy markcassidy requested a review from a team March 24, 2020 04:24
@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

Copy link

@ciprianbadescu ciprianbadescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge after the two cosmetic changes

@ciprianbadescu ciprianbadescu requested a review from a team March 27, 2020 18:02
@gimmyxd gimmyxd changed the title Enable Windows hosts to use the package_proxy to download the package (maint) Enable Windows hosts to use the package_proxy Mar 30, 2020
@gimmyxd gimmyxd merged commit 0a42db5 into puppetlabs:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants