Merge pull request #219 from bastelfreak/strict

CI: Build gems with strictness and verbosity & dependencies: Add version constraints
puppetlabs · May 5, 2023 · 86d2b3c · 86d2b3c
2 parents cbc979d + d3924d9
commit 86d2b3c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -18,7 +18,7 @@ jobs:
         env:
           BUNDLE_WITHOUT: release
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Publish gem to rubygems.org
         run: gem push *.gem
         env:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -47,7 +47,7 @@ jobs:
       - name: spec tests
         run: bundle exec rake test:spec
       - name: Verify gem builds
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
 
   tests:
     needs:

diff --git a/beaker-puppet.gemspec b/beaker-puppet.gemspec
@@ -23,13 +23,13 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'fakefs', '>= 0.6', '< 2.0'
   s.add_development_dependency 'rake', '~> 13.0'
   s.add_development_dependency 'rspec', '~> 3.0'
-  s.add_development_dependency 'rspec-its'
+  s.add_development_dependency 'rspec-its', '~> 1.3'
   s.add_development_dependency 'voxpupuli-rubocop', '~> 1.2'
 
   # Acceptance Testing Dependencies
-  s.add_development_dependency 'beaker-vmpooler'
+  s.add_development_dependency 'beaker-vmpooler', '~> 1.4'
 
   # Run time dependencies
   s.add_runtime_dependency 'beaker', '~> 4.1'
-  s.add_runtime_dependency 'oga'
+  s.add_runtime_dependency 'oga', '~> 3.4'
 end