chore: waitForNavigation should fail if navigation aborts or fails (#…

…11914)
puppeteer · Feb 15, 2024 · bd4d0fe · bd4d0fe
1 parent 634d5b8
commit bd4d0fe
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/packages/puppeteer-core/src/bidi/Frame.ts b/packages/puppeteer-core/src/bidi/Frame.ts
@@ -309,7 +309,19 @@ export class BidiFrame extends Frame {
         fromEmitterEvent(this.browsingContext, 'navigation').pipe(
           switchMap(({navigation}) => {
             return this.#waitForLoad$(options).pipe(
-              raceWith(fromEmitterEvent(navigation, 'fragment')),
+              raceWith(
+                fromEmitterEvent(navigation, 'fragment'),
+                fromEmitterEvent(navigation, 'failed').pipe(
+                  map(({url}) => {
+                    throw new Error(`Navigation failed: ${url}`);
+                  })
+                ),
+                fromEmitterEvent(navigation, 'aborted').pipe(
+                  map(({url}) => {
+                    throw new Error(`Navigation aborted: ${url}`);
+                  })
+                )
+              ),
               map(() => {
                 return navigation;
               })