test: do not use quirks mode for test files (#11930)

puppeteer · Feb 16, 2024 · aef584c · aef584c
1 parent eea5884
commit aef584c
Show file tree

Hide file tree

Showing 54 changed files with 54 additions and 2 deletions.
diff --git a/test/assets/abort-request.html b/test/assets/abort-request.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <button id="abort"></button>
 
 <script>

diff --git a/test/assets/beforeunload.html b/test/assets/beforeunload.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <div>beforeunload demo.</div>
 <script>
 window.addEventListener('beforeunload', event => {

diff --git a/test/assets/cached/bfcache/worker-iframe-container.html b/test/assets/cached/bfcache/worker-iframe-container.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <body>BFCached<a href="target.html">next</a></body>
 <script>
   window.addEventListener('DOMContentLoaded', () => {

diff --git a/test/assets/cached/bfcache/worker-iframe.html b/test/assets/cached/bfcache/worker-iframe.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
   const worker = new Worker('worker.mjs', {type: 'module'})
 </script>
diff --git a/test/assets/cached/one-style-font.html b/test/assets/cached/one-style-font.html
@@ -1,2 +1,3 @@
+<!DOCTYPE html>
 <link rel='stylesheet' href='./one-style-font.css'>
 <div>hello, world!</div>
diff --git a/test/assets/cached/one-style.html b/test/assets/cached/one-style.html
@@ -1,2 +1,3 @@
+<!DOCTYPE html>
 <link rel='stylesheet' href='./one-style.css'>
 <div>hello, world!</div>
diff --git a/test/assets/csp.html b/test/assets/csp.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <meta http-equiv="Content-Security-Policy" content="default-src 'self'">
diff --git a/test/assets/csscoverage/empty.html b/test/assets/csscoverage/empty.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style></style>
 <div>empty style tag</div>
 
diff --git a/test/assets/csscoverage/involved.html b/test/assets/csscoverage/involved.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 @charset "utf-8";
 @namespace svg url(http://www.w3.org/2000/svg);

diff --git a/test/assets/csscoverage/media.html b/test/assets/csscoverage/media.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 @media screen { div { color: green; } } </style>
 <div>hello, world</div>

diff --git a/test/assets/csscoverage/multiple.html b/test/assets/csscoverage/multiple.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <link rel="stylesheet" href="stylesheet1.css">
 <link rel="stylesheet" href="stylesheet2.css">
 <script>

diff --git a/test/assets/csscoverage/simple.html b/test/assets/csscoverage/simple.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 div { color: green; }
 a { color: blue; }

diff --git a/test/assets/csscoverage/sourceurl.html b/test/assets/csscoverage/sourceurl.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 body {
   padding: 10px;

diff --git a/test/assets/csscoverage/unused.html b/test/assets/csscoverage/unused.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 @media screen {
   a { color: green; }

diff --git a/test/assets/dynamic-oopif.html b/test/assets/dynamic-oopif.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 window.addEventListener('DOMContentLoaded', () => {
   const iframe = document.createElement('iframe');

diff --git a/test/assets/empty.html b/test/assets/empty.html
@@ -0,0 +1 @@
+<!DOCTYPE html>
diff --git a/test/assets/error.html b/test/assets/error.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 a();
 

diff --git a/test/assets/frames/frame.html b/test/assets/frames/frame.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <link rel='stylesheet' href='./style.css'>
 <script src='./script.js' type='text/javascript'></script>
 <style>

diff --git a/test/assets/frames/frameset.html b/test/assets/frames/frameset.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <frameset>
   <frameset>
     <frame src='./frame.html'></frame>

diff --git a/test/assets/frames/lazy-frame.html b/test/assets/frames/lazy-frame.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <iframe width="100%" height="300" src="about:blank"></iframe>
 <div style="height: 800vh"></div>
 <iframe width="100%" height="300" src='./frame.html' loading="lazy"></iframe>
diff --git a/test/assets/frames/nested-frames.html b/test/assets/frames/nested-frames.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 :root {
   scrollbar-width: none;

diff --git a/test/assets/frames/one-frame-url-fragment.html b/test/assets/frames/one-frame-url-fragment.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <iframe src='./frame.html?param=value#fragment'></iframe>
diff --git a/test/assets/frames/one-frame.html b/test/assets/frames/one-frame.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <iframe src='./frame.html'></iframe>
diff --git a/test/assets/frames/two-frames.html b/test/assets/frames/two-frames.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 body {
     display: flex;

diff --git a/test/assets/global-var.html b/test/assets/global-var.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 var globalVar = 123;
 </script>
diff --git a/test/assets/grid.html b/test/assets/grid.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 document.addEventListener('DOMContentLoaded', function() {
     function generatePalette(amount) {

diff --git a/test/assets/historyapi.html b/test/assets/historyapi.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 window.addEventListener('DOMContentLoaded', () => {
   history.pushState({}, '', '#1');

diff --git a/test/assets/initiator.html b/test/assets/initiator.html
@@ -1,2 +1,3 @@
+<!DOCTYPE html>
 <iframe src="./frames/frame.html"></iframe>
 <script src="./initiator.js"></script>
diff --git a/test/assets/inner-frame1.html b/test/assets/inner-frame1.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
   window.addEventListener('DOMContentLoaded', () => {
     const iframe = document.createElement('iframe');

diff --git a/test/assets/inner-frame2.html b/test/assets/inner-frame2.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <button>click</button>
diff --git a/test/assets/input/touchscreen.html b/test/assets/input/touchscreen.html
@@ -1,4 +1,4 @@
-<!doctype html>
+<!DOCTYPE html>
 <html>
   <head>
     <title>Touch test</title>

diff --git a/test/assets/jscoverage/eval.html b/test/assets/jscoverage/eval.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <script>eval('console.log("foo")')</script>
diff --git a/test/assets/jscoverage/involved.html b/test/assets/jscoverage/involved.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 function foo() {
   if (1 > 2)

diff --git a/test/assets/jscoverage/multiple.html b/test/assets/jscoverage/multiple.html
@@ -1,2 +1,3 @@
+<!DOCTYPE html>
 <script src='script1.js'></script>
 <script src='script2.js'></script>
diff --git a/test/assets/jscoverage/ranges.html b/test/assets/jscoverage/ranges.html
@@ -1,2 +1,3 @@
+<!DOCTYPE html>
 <script>
 function unused(){}console.log('used!');if(true===false)console.log('unused!');</script>
diff --git a/test/assets/jscoverage/simple.html b/test/assets/jscoverage/simple.html
@@ -1,2 +1,3 @@
+<!DOCTYPE html>
 <script>
 function foo() {function bar() { } console.log(1); } foo(); </script>
diff --git a/test/assets/jscoverage/sourceurl.html b/test/assets/jscoverage/sourceurl.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 console.log(1);
 //# sourceURL=nicename.js

diff --git a/test/assets/jscoverage/unused.html b/test/assets/jscoverage/unused.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <script>function foo() { }</script>
diff --git a/test/assets/lazy-oopif-frame.html b/test/assets/lazy-oopif-frame.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <iframe width="100%" height="300" src="about:blank"></iframe>
 <div style="height: 800vh"></div>
 <iframe width="100%" height="300" src="https://www.example.com" loading="lazy"></iframe>
diff --git a/test/assets/main-frame.html b/test/assets/main-frame.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
   window.addEventListener('DOMContentLoaded', () => {
     const iframe = document.createElement('iframe');

diff --git a/test/assets/mobile.html b/test/assets/mobile.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <meta name = "viewport" content = "initial-scale = 1, user-scalable = no">
diff --git a/test/assets/networkidle.html b/test/assets/networkidle.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
   async function sleep(delay) {
     return new Promise(resolve => setTimeout(resolve, delay));

diff --git a/test/assets/one-style.html b/test/assets/one-style.html
@@ -1,2 +1,3 @@
+<!DOCTYPE html>
 <link rel='stylesheet' href='./one-style.css'>
 <div>hello, world!</div>
diff --git a/test/assets/oopif.html b/test/assets/oopif.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <a id="navigate-within-document" href="#nav">Navigate within document</a>  
 <a name="nav"></a>
 <script>

diff --git a/test/assets/p-selectors.html b/test/assets/p-selectors.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <div id="a">hello <button id="b">world</button>
     <span id="f"></span>
     <div id="c"></div>

diff --git a/test/assets/resetcss.html b/test/assets/resetcss.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 /* http://meyerweb.com/eric/tools/css/reset/
    v2.0 | 20110126

diff --git a/test/assets/self-request.html b/test/assets/self-request.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 var req = new XMLHttpRequest();
 req.open('GET', '/self-request.html');

diff --git a/test/assets/serviceworkers/empty/sw.html b/test/assets/serviceworkers/empty/sw.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
   window.registrationPromise = navigator.serviceWorker.register('sw.js');
 </script>
diff --git a/test/assets/serviceworkers/fetch/sw.html b/test/assets/serviceworkers/fetch/sw.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <link rel="stylesheet" href="./style.css">
 <script>
   window.registrationPromise = navigator.serviceWorker.register('sw.js');

diff --git a/test/assets/shadow.html b/test/assets/shadow.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
 
 let h1 = null;

diff --git a/test/assets/tamperable.html b/test/assets/tamperable.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <script>
     window.result = window.injected;
 </script>
diff --git a/test/assets/title.html b/test/assets/title.html
@@ -1 +1,2 @@
+<!DOCTYPE html>
 <title>Woof-Woof</title>
diff --git a/test/assets/wrappedlink.html b/test/assets/wrappedlink.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <style>
 :root {
   font-family: monospace;

diff --git a/test/src/page.spec.ts b/test/src/page.spec.ts
@@ -1232,7 +1232,7 @@ describe('Page', function () {
         page.goto(server.PREFIX + '/error.html'),
       ]);
       expect(error.message).toContain('Fancy');
-      expect(error.stack?.split('\n')[1]).toContain('error.html:13');
+      expect(error.stack?.split('\n').at(-1)).toContain('error.html:3:1');
     });
   });