Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdbc FiberConnection doesn't use Fibers where appropriate #27

Closed
hsestupin opened this issue Apr 21, 2015 · 2 comments
Closed

Jdbc FiberConnection doesn't use Fibers where appropriate #27

hsestupin opened this issue Apr 21, 2015 · 2 comments
Assignees
Labels

Comments

@hsestupin
Copy link

Hi, may be I'm misunderstood something. Is there any reason behind that fibers aren't used in every FiberConnection method which throws SQLException exception. For example java.sql.Connection#commit is a blocking method undoubtedly. Why don't we have to wrap it to something like this:

FiberAsync.runBlocking(exec, new CheckedCallable<Void, SQLException>() {

    @Override
    public Void call() throws SQLException {
        return conn.commit();
    }
});
@circlespainter circlespainter self-assigned this Apr 21, 2015
@circlespainter
Copy link
Member

Thanks for reporting this, I'll look into it very soon. Yes, they should really be fiber-blocking.

@circlespainter
Copy link
Member

Fixed with this branch that will be merged into master to enter next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants