fix(bgmv): write shared_memory y_warpsize only when threadIdx.x == 0 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
approved these changes
May 22, 2024
There was a problem hiding this comment.
@menggeliu1205 thanks for the bugfix and it looks good to me.
An alternative fix is to add a sum = __shfl_sync(0xffffffff, sum, 0); before y_warpwise[threadIdx.y] ... to broadcast the reduction result from lane 0 to all lanes in the warp, either fix should work.
|
thanks for replying and offer the other fix! i get it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should add threadIdx.x == 0, when you want to write y_warpsize. Otherwise it will lead the wrong answer.