-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMAX effect integration #98
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
- Coverage 93.51% 93.13% -0.38%
===========================================
Files 9 9
Lines 447 481 +34
===========================================
+ Hits 418 448 +30
- Misses 29 33 +4 ☔ View full report in Codecov by Sentry. |
@s0larish could you take a look at the TODOs @lowderchris left in the code? We should make sure we have answers to those before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see more tests. Is there a simple test case for IMAX matrix we can generate to actually check the values? We need to make sure the matrix is properly constructed. Or could we make sure its output is different when its applied than not applied. It would be particularly nice if the ratio of output with and without the IMAX effect has a nice property we can check for. I'm just brainstorming some tests here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. These should be easy things to fix I think.
I've migrated some of the IMAX effect code from punchbowl to here in solpolpy directly. A punchbowl branch exists utilizing these changes, which can be pulled in once this pull request is resolved. Definitely let me know of any changes I can make here to improve. See any TODOs for outstanding questions I can wrap up.