Issue techjoomla#48 chore: code review changes

punambaravkar · Jun 26, 2019 · cdbcbe3 · cdbcbe3
1 parent e0ff5b4
commit cdbcbe3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/src/com_tjnotifications/admin/sql/install.mysql.utf8.sql b/src/com_tjnotifications/admin/sql/install.mysql.utf8.sql
@@ -55,16 +55,16 @@ CREATE TABLE IF NOT EXISTS `#__tj_notification_logs` (
   `id` int(11) NOT NULL AUTO_INCREMENT,
   `key` varchar(100) NOT NULL,
   `client` varchar(100) NOT NULL,
-  `provider` varchar(100) NOT NULL,
+  `provider` varchar(50) NOT NULL,
   `subject` varchar(250) NOT NULL,
   `title` varchar(100) NOT NULL,
   `body` text NOT NULL,
-  `from` varchar(100) NOT NULL,
-  `to` varchar(100) NOT NULL,
-  `cc` varchar(100) NOT NULL,
-  `bcc` varchar(100) NOT NULL,
+  `from` varchar(500) NOT NULL,
+  `to` text NOT NULL,
+  `cc` text NOT NULL,
+  `bcc` text NOT NULL,
   `date` date NOT NULL,
-  `state` int(11) NOT NULL,
+  `state` tinyint(2) NOT NULL,
   `params` text NOT NULL,
   `priority`int(11) NOT NULL,
   `message` text NOT NULL,

diff --git a/src/com_tjnotifications/admin/sql/updates/mysql/1.1.0.sql b/src/com_tjnotifications/admin/sql/updates/mysql/1.1.0.sql
@@ -5,16 +5,16 @@ CREATE TABLE IF NOT EXISTS `#__tj_notification_logs` (
   `id` int(11) NOT NULL AUTO_INCREMENT,
   `key` varchar(100) NOT NULL,
   `client` varchar(100) NOT NULL,
-  `provider` varchar(100) NOT NULL,
+  `provider` varchar(50) NOT NULL,
   `subject` varchar(250) NOT NULL,
   `title` varchar(100) NOT NULL,
   `body` text NOT NULL,
-  `from` varchar(100) NOT NULL,
-  `to` varchar(100) NOT NULL,
-  `cc` varchar(100) NOT NULL,
-  `bcc` varchar(100) NOT NULL,
+  `from` varchar(500) NOT NULL,
+  `to` text NOT NULL,
+  `cc` text NOT NULL,
+  `bcc` text NOT NULL,
   `date` date NOT NULL,
-  `state` int(11) NOT NULL,
+  `state` tinyint(2) NOT NULL,
   `params` text NOT NULL,
   `priority`int(11) NOT NULL,
   `message` text NOT NULL,
@@ -23,4 +23,3 @@ CREATE TABLE IF NOT EXISTS `#__tj_notification_logs` (
 )
  DEFAULT CHARSET=utf8
  AUTO_INCREMENT=0 ;
-