fix(reporter/base): string diff - issue mochajs#1241

Show string diff as a raw data, this fix issue mochajs#1241.
pumpupapp · Apr 18, 2015 · 2491ea0 · 2491ea0
1 parent 0feb772
commit 2491ea0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/lib/reporters/base.js b/lib/reporters/base.js
@@ -189,11 +189,9 @@ exports.list = function(failures){
     if (err.showDiff !== false && sameType(actual, expected)
         && expected !== undefined) {
 
-      if ('string' !== typeof actual) {
-        escape = false;
-        err.actual = actual = utils.stringify(actual);
-        err.expected = expected = utils.stringify(expected);
-      }
+      escape = false;
+      err.actual = actual = utils.stringify(actual);
+      err.expected = expected = utils.stringify(expected);
 
       fmt = color('error title', '  %s) %s:\n%s') + color('error stack', '\n%s\n');
       var match = message.match(/^([^:]+): expected/);

diff --git a/lib/utils.js b/lib/utils.js
@@ -455,7 +455,7 @@ function jsonStringify(object, spaces, depth) {
       default:
         val = (val == '[Function]' || val == '[Circular]')
           ? val
-          : '"' + val + '"'; //string
+          : JSON.stringify(val); //string
     }
     return val;
   }

diff --git a/test/reporters/base.js b/test/reporters/base.js
@@ -88,22 +88,24 @@ describe('Base reporter', function () {
 
   });
 
-  it('should not stringify strings', function () {
+  it('should show string diff as raw data', function () {
     var err = new Error('test'),
       errOut;
 
-    err.actual = "a1";
-    err.expected = "e2";
+    err.actual = 'foo\nbar';
+    err.expected = 'foo\nbaz';
     err.showDiff = true;
     var test = makeTest(err);
 
     Base.list([test]);
 
     errOut = stdout.join('\n');
-    errOut.should.not.match(/"/);
+
+    errOut.should.match(/"foo\\nbar"/);
+    errOut.should.match(/"foo\\nbaz"/);
     errOut.should.match(/test/);
-    errOut.should.match(/\- actual/);
-    errOut.should.match(/\+ expected/);
+    errOut.should.match(/actual/);
+    errOut.should.match(/expected/);
   });
 
   it('should stringify objects', function () {