allow sending key/value pairs with dispatch #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
reviewed
Dec 12, 2023
Make pulumictl dispatch more generally useful, and allow key/value pairs in addition to a single ref. For starters we'll use this to dispatch a GitHub actions job that will update the `latest-dev-version` file (see pulumi/docs#10365), but this can be used for other workflows as well.
tgummerer
force-pushed
the
tg/create-dev-version
branch
from
1c9feb7
to
61b2ac1
Compare
tgummerer
changed the title
Frassle
requested changes
Dec 13, 2023
cmd/pulumictl/dispatch/cli.go
Outdated
| @@ -53,7 +64,6 @@ func Command() *cobra.Command { | |||
| } | |||
|
|
|||
| _, err := semver.Parse(gitversion.StripModuleTagPrefixes(ref)) | |||
There was a problem hiding this comment.
This semver check needs moving into the payloadMap["ref"] side of the if above.
There was a problem hiding this comment.
Linting didn't pick this up because there's global var defined at line 22. That can go but I'm pretty sure the others can probably go as well.
There was a problem hiding this comment.
Ah yes, good catch, thanks!
Yeah indeed, all the global variables can go. In fact that made me realize that we never actually used the org variable, and that command line parameter doesn't do anything. I removed it now.
Frassle
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make pulumictl dispatch more generally useful, and allow key/value pairs in addition to a single ref. For starters we'll use this to dispatch a GitHub actions job that will update the
latest-dev-versionfile (see pulumi/docs#10365), but this can be used for other workflows as well./xref pulumi/pulumi#14623