Fix argument parsing bugs by using dedicated Viper instances #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stopped working as expected, instead generating a --generic style version:
The first bad commit is f5ca64e and last good commit is 2218df7.
It turns out the issue is with viper arg parsing. Introducing a new "github.com/pulumi/pulumictl/cmd/pulumictl/convert-version" module with a new command reused the global viper instance. So this got called twice in different commands:
And it broke. Basically the new convert-version command broke the old
get version
command.This is rather alarming, so the fix introduces dedicated viper state into every sub-command to avoid this collision in the future.