Add support for overriding plugin download URLs #8798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
force-pushed
the
justin/url-override
branch
from
7faa594 to
c139003
Compare
Codecov Report
@@ Coverage Diff @@
## master #8798 +/- ##
==========================================
+ Coverage 59.38% 59.39% +0.01%
==========================================
Files 637 637
Lines 97911 97943 +32
Branches 1386 1386
==========================================
+ Hits 58141 58177 +36
+ Misses 36491 36482 -9
- Partials 3279 3284 +5
Continue to review full report at Codecov.
|
Frassle
approved these changes
Jan 21, 2022
t0yv0
approved these changes
Jan 21, 2022
This commit adds a variable that can be set with a linker flag to override the plugin download URL for matching plugin names. For example, compiling the Pulumi CLI with the following linker flag: - `-X [module path]/workspace.pluginDownloadURLOverrides=^foo.*=https://foo,^bar.*=https://bar` Would make it so that plugin names that start with "foo" are downloaded from https://foo and names that start with "bar" are downloaded from https://bar.
justinvp
force-pushed
the
justin/url-override
branch
from
c139003 to
ab6745a
Compare
The exact same thought process went through my head. |
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
… the package (#16186) <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description Overriding plugin download URLs with compilation flags was originally added in #8798. Its intent was allowing our customers to override download locations for all plugins, so that only trusted pre-approved plugins could be downloaded. Since then, we've added `PluginDownloadURL` for a package, which is the default URL for that package's binary if it's shipped outside our Pulumi org. Currently, `PluginDownloadURL` takes precedence over `pluginDownloadURLOverrides`, which means it's impossible to override third-party package binary locations. This PR changes plugin source resolution to flip the priority of those two. If an override matches regex, its URL will take priority over the default `PluginDownloadURL` specified in the package. I have added tests to verify `pluginDownloadURLOverrides` with and without `PluginDownloadURL`. The second one fails before my change. Resolves #16058 ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a variable that can be set with a linker flag to override the plugin download URL for matching plugin names.
For example, compiling the Pulumi CLI with the following linker flag:
-X [module path]/workspace.pluginDownloadURLOverrides=^foo.*=https://foo,^bar.*=https://barWould make it so that plugin names that start with "foo" are downloaded from https://foo and names that start with "bar" are downloaded from https://bar.
Checklist