Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auto/dotnet] - plugin installation options: exact version, server #7796

Merged
merged 6 commits into from
Aug 24, 2021
Merged

[auto/dotnet] - plugin installation options: exact version, server #7796

merged 6 commits into from
Aug 24, 2021

Conversation

orionstudt
Copy link
Contributor

@orionstudt orionstudt commented Aug 19, 2021 •
edited
Loading

Description

Add functionality to .NET Automation API to allow for the --exact and --server arguments when doing pulumi plugin install. Related to #7742.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@t0yv0 t0yv0 self-requested a review August 19, 2021 15:58
@t0yv0
Copy link
Member

t0yv0 commented Aug 19, 2021

/run-acceptance-tests

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@emiliza emiliza added this to the 0.61 milestone Aug 19, 2021
justinvp
justinvp reviewed Aug 20, 2021
View reviewed changes
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/PluginInstallOptions.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/Workspace.cs Outdated Show resolved Hide resolved
@orionstudt @justinvp
Apply suggestions from code review
8fb2a5f 
Co-authored-by: Justin Van Patten <[email protected]>
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

justinvp
justinvp approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside from updating the CHANGELOG entry)

CHANGELOG_PENDING.md Outdated Show resolved Hide resolved
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@t0yv0
Copy link
Member

t0yv0 commented Aug 23, 2021

/run-acceptance-tests

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@t0yv0
Copy link
Member

t0yv0 commented Aug 23, 2021

Thanks so much @orionstudt

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@t0yv0 t0yv0 mentioned this pull request Aug 24, 2021
Closed
3 tasks
@t0yv0 t0yv0 merged commit 51b4f3d into pulumi:master Aug 24, 2021
@orionstudt orionstudt deleted the auto/dotnet-plugin-install-server branch August 24, 2021 23:22
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
@orionstudt @justinvp
[auto/dotnet] - plugin installation options: exact version, server (p…
df72629 
…ulumi/pulumi#7796)

* add additional plugin install options

* update changelog

* slight re-name properties to be more idiomatic

* Apply suggestions from code review

Co-authored-by: Justin Van Patten <[email protected]>

* Add support for old install plugin overload, and move unshipped api changes to shipped

* add breaking note to changelog

Co-authored-by: Justin Van Patten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailshilkov mikhailshilkov mikhailshilkov left review comments

@justinvp justinvp justinvp approved these changes

@t0yv0 t0yv0 Awaiting requested review from t0yv0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.61
Development

Successfully merging this pull request may close these issues.
5 participants
@orionstudt @t0yv0 @justinvp @mikhailshilkov @emiliza