Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[automation] - Consume config set-all and rm-all commands #6388

Merged
merged 2 commits into from
Feb 20, 2021
Merged

[automation] - Consume config set-all and rm-all commands #6388

merged 2 commits into from
Feb 20, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Feb 19, 2021 •
edited
Loading

Go Benchmark Results

Before

  • Mixed (10 secret, 10 plain): 11.69s
  • Mixed (20 secret, 20 plain): 24.85s
  • Plain (20 plain): 11.25s
  • Plain (40 plain): 26.39s
  • Secret (20 secret): 12.29s
  • Secret (40 secret): 25.36s

After

  • Mixed (10 secret, 10 plain): 1.18s
  • Mixed (20 secret, 20 plain): 1.55s
  • Plain (20 plain): 1.05s
  • Plain (40 plain): 1.20s
  • Secret (20 secret): 1.51s
  • Secret (40 secret): 2.54s

Related to: #6373

@komalali komalali force-pushed the komalali/auto-all-config branch from 3741133 to cf5cbfe Compare February 19, 2021 07:13
@komalali komalali force-pushed the komalali/set-all-config branch from 35e2d7c to b781df0 Compare February 20, 2021 03:29
@komalali komalali force-pushed the komalali/auto-all-config branch from cf5cbfe to 454b8e0 Compare February 20, 2021 03:35
Base automatically changed from komalali/set-all-config to master February 20, 2021 05:56
@komalali komalali force-pushed the komalali/auto-all-config branch from 984c0c9 to fa6ac34 Compare February 20, 2021 05:59
@komalali komalali marked this pull request as ready for review February 20, 2021 06:09
This was linked to issues Feb 20, 2021
Slow performance for stack.setAllConfig #6042
Closed
[auto/js] Concurrency issue with bulk config set #6050
Closed
@komalali komalali merged commit 5f4e687 into master Feb 20, 2021
@komalali komalali deleted the komalali/auto-all-config branch February 20, 2021 06:59
@komalali komalali mentioned this pull request Feb 21, 2021
Open
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
@komalali
[automation] - Consume config set-all and rm-all commands (pulumi/pul…
0fbdaac 
…umi#6388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[auto/js] Concurrency issue with bulk config set Slow performance for stack.setAllConfig
2 participants
@komalali @justinvp