Remove unused npm dependencies #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like these dependencies aren't actually used anywhere, so stop depending on them. The motivation for this change is that the dependency on `resolve` causes errors to be logged in logs during plugin discovery, because the package includes tests that have malformed `package.json` files. If we don't actually need the dependency it'd be nice to remove it so those errors are no longer logged (so users don't ask us about them). Also remove `read-package-tree` since it is deprecated. Also remove `builtin-modules` since it doesn't appear to be used either.
justinvp
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 4 4
======================================
Misses 4 4 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these dependencies aren't actually used anywhere, so stop depending on them.
The motivation for this change is that the dependency on
resolvecauses errors to be logged in logs during plugin discovery, because the package includes tests that have malformedpackage.jsonfiles. If we don't actually need the dependency it'd be nice to remove it so those errors are no longer logged (so users don't ask us about them).Also remove
read-package-treesince it is deprecated.Also remove
builtin-modulessince it doesn't appear to be used either.Similar to pulumi/pulumi-aws#3238, pulumi/pulumi-aws#4971, pulumi/pulumi-gitlab#786, and pulumi/pulumi-digitalocean#914
Reference: pulumi/pulumi#17578