Add option to filter edit rules by location in docs conversion pipeline and apply for installation docs

[guineveresaenger]

This code is required to successfully apply the edit rules needed for pulumi/pulumi-libvirt#426.

It covers the case for when the upstream file's code sections need to be adjusted for code conversion to work.

It adds a complete index file test which tests the entire plainDocsParser function.
In support of https://github.com/pulumi/home/issues/3598.

• Run provider-supplied edit rules before example conversion. Add complete file tests, with and without provider-supplied edits
• clean up tests

[codecov]

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.12%. Comparing base (1cb7594) to head (cdf7074).
Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/tfgen/installation_docs.go	50.00%	7 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
- Coverage   57.43%   57.12%   -0.31%     
==========================================
  Files         369      370       +1     
  Lines       50209    51030     +821     
==========================================
+ Hits        28836    29152     +316     
- Misses      19795    20289     +494     
- Partials     1578     1589      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iwahbe]

When edit rules are applied is important. Can we add a note to info.DocsEdit that tells the user "your edit will be applied before any other edits"?

I think the change is OK as is, but it also feels like this makes edit rules application even more complicated and special for installation docs.

We can merge as is if we really need to, but I'd love if we took the opportunity to re-unify behavior for edit rules. For that, see 👇.

---

Instead of making bridge supplied edit rules special, I propose that we:

1. Add a field to info.DocsEdit to control where the edit rule is applied. Initially, I would suggest an enum with: EditPreTranslation (the zero value, since this is what we do for normal pages) and EditPostTranslation.
2. Edit apply to also take a phase (pre or post) and then filter edit rules applied.
3. Move the existing "special" edit rules for installation docs into defaultEditRules (in edit_rules.go), specifying EditPostTranslation as needed.

[guineveresaenger]

Hmm, I like this idea, and I think that edit rules should be applied mostly after code conversion. The main case for applying them pre-conversion is to fix any mistakes in the provided code, as was discovered here. Having both options would not only allow us to fix incorrect TF code and make it convertable (convertible? 🚗 ), but also give us far more freedom in translating "Terraform" strings for "Pulumi" ones.

[iwahbe]

I have some comment nits, but otherwise LGTM

[pulumi-bot]

This PR has been shipped in release v3.92.0.