Adjust documentation for Elem() #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toward fixing #1828 Document current findings and add tests for PF representations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2187 +/- ##
=======================================
Coverage 60.65% 60.65%
=======================================
Files 350 350
Lines 45930 45930
=======================================
Hits 27857 27857
Misses 16533 16533
Partials 1540 1540 ☔ View full report in Codecov by Sentry. |
|
Looks like PF has an ObjectAttribute as well, let me test that. |
t0yv0
commented
Jul 16, 2024
pf/tests/repr_test.go
Outdated
| autogold.Expect(`{ | ||
| "resources": { | ||
| "_": { | ||
| "object_attribute": { |
There was a problem hiding this comment.
Interestingly enough this may look like a single-nested block to shim.Schema; it doesn't carry the distinction is it an attr or block in shim.Schema. May be allright for now but can cause some trouble in the corner cases perhaps.
iwahbe
approved these changes
Jul 16, 2024
|
This PR has been shipped in release v3.87.0. |
VenelinMartinov
added a commit
that referenced
this pull request
Jul 23, 2024
Follow up on #2187 with shim translation tests for sdkv2 schemas. In sdkv2 the translations map 1:1 as far as I can tell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward fixing #1828
Document current findings and add tests for PF representations.