More unknowns tests for diff #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
commented
Jun 27, 2024
| + prov:index/test:Test: (create) | ||
| [urn=urn:pulumi:test::test::prov:index/test:Test::mainRes] | ||
| tests : [ | ||
| [0]: {} |
There was a problem hiding this comment.
this is an unknown array
| [urn=urn:pulumi:test::test::prov:index/test:Test::mainRes] | ||
| ~ tests: [ | ||
| ~ [0]: { | ||
| - testProp: "known_val" |
There was a problem hiding this comment.
The new value is unknown - this just shows us removing the old value.
| [urn=urn:pulumi:test::test::prov:index/nestedTest:NestedTest::mainRes] | ||
| ~ tests: [ | ||
| ~ [0]: { | ||
| - nestedProps: [ |
There was a problem hiding this comment.
The diff here is duplicated?
| tests : [ | ||
| [0]: { | ||
| nestedProps: [ | ||
| [0]: {} |
There was a problem hiding this comment.
Unknown array shown as just an array with a single empty object
| ~ [0]: { | ||
| ~ nestedProps: [ | ||
| ~ [0]: { | ||
| - testProps: [ |
There was a problem hiding this comment.
duplicated diff again
| ~ nestedProps: [ | ||
| ~ [0]: { | ||
| ~ testProps: [ | ||
| ~ [0]: "known_val" => output<string> |
There was a problem hiding this comment.
unknown at the wrong level
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 60.64% 60.63% -0.01%
==========================================
Files 350 350
Lines 45898 45898
==========================================
- Hits 27833 27829 -4
- Misses 16526 16529 +3
- Partials 1539 1540 +1 ☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v3.86.0. |
VenelinMartinov
added a commit
that referenced
this pull request
Jul 17, 2024
This changes the bridge to correctly return unknowns for objects and collections in sdkv2. fixes #1885 fixes #2032 stacked on #2158 Confirmed that TF sdkv2 supports both unknown blocks and unknown collections of blocks, so we should be fine to pass these into TF providers. The TF sdkv1 does not support unknowns for blocks and collections so we keep the old behaviour of passing empty/ collection of unknown. <details> ```hcl provider "google" { region = "us-central1" } resource "google_storage_bucket" "bucket" { name = "example-bucket12312322312" location = "US" } resource "google_storage_bucket" "bucket1" { name = "example-bucket123123223" location = "US" dynamic "lifecycle_rule" { for_each = google_storage_bucket.bucket.effective_labels content { action { type = lifecycle_rule.value } condition { age = 1 } } } } ``` </details> This returns `"lifecycle_rule":cty.UnknownVal(cty.List(cty.Object))` Our handling of collections containing unknowns and unknown collections is significantly better: Unknown collections: before: ``` + prov:index/test:Test: (create) [urn=urn:pulumi:test::test::prov:index/test:Test::mainRes] tests : [ [0]: {} ] ``` after: ``` + prov:index/test:Test: (create) [urn=urn:pulumi:test::test::prov:index/test:Test::mainRes] tests : output<string> ``` Note that the array being output as an `output<string>` is an engine limitation. Nested unknown collections: before: ``` + prov:index/nestedTest:NestedTest: (create) [urn=urn:pulumi:test::test::prov:index/nestedTest:NestedTest::mainRes] tests : [ [0]: { nestedProps: [ [0]: { testProps : [ [0]: output<string> ] } ] } ] ``` after: ``` + prov:index/nestedTest:NestedTest: (create) [urn=urn:pulumi:test::test::prov:index/nestedTest:NestedTest::mainRes] tests : [ [0]: { nestedProps: [ [0]: { testProps : output<string> } ] } ] ``` The unknown was being put one level lower than it should be. Quite a few other very wrong outputs in #2140, including diff duplications, missing diffs etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the tests from #2061 to make the effect of the changes obvious.
The tests mostly focus around the way unknowns are displayed in diffs.
Some of the outputs here are very clearly wrong. I've annotated most of them but they are all fixed in 2061