Refactor TestTerraformOutputsWithSecretsSupported #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests This is only a refactor of test code for clarity.
t0yv0
reviewed
Apr 11, 2024
| Schema: schemaMap(map[string]*schema.Schema{ | ||
| "secret_value": { | ||
| Type: shim.TypeString, | ||
| Sensitive: true, |
t0yv0
approved these changes
Apr 11, 2024
VenelinMartinov
approved these changes
Apr 12, 2024
iwahbe
force-pushed
the
iwahbe/refactor-TestTerraformOutputsWithSecretsSupported
branch
from
99b8570 to
36c1766
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 60.99% 60.48% -0.52%
==========================================
Files 303 310 +7
Lines 42457 42835 +378
==========================================
+ Hits 25898 25908 +10
- Misses 15085 15454 +369
+ Partials 1474 1473 -1 ☔ View full report in Codecov by Sentry. |
iwahbe
deleted the
iwahbe/refactor-TestTerraformOutputsWithSecretsSupported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1853.
Since #1851 also edits these tests, I thought they should also have (and require) correct types.