Fix unexplained detailed diffs #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
added a commit
that referenced
this pull request
Sep 17, 2024
This exposes the detailed diff in the cross-test interface for both TF and Pulumi allowing us to write tests which assert on that. Also adds a cross-test for #1696 for the existing `TestChangingMaxItems1FilterProperty`. This is one of the cases where the detailed diff is load-bearing for the diff decision. The cross test verifies that TF also finds a diff here, so our core diff algorithm must be making the wrong decision. Related to #2293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pulumi/pulumi-aws#3439
makeDetailedDiff does not report collection changes. It instead hopes that elements of the collection will produce diff entries. When changes involve collections all the way down and there are no element entries, makeDetailedDiff produces no records.
However we have some workarounds now that produce a DIFF_SOME even when there are no entries per
#1501
The change in this PR embellishes this case with collection-level diffs so there is at least something to show.