Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tfgen summary percentages #1453

Closed
wants to merge 2 commits into from

Conversation

VenelinMartinov
Copy link
Contributor

Should address #1348.
Adds percentages to all the metrics output in the tfgen summary.

@VenelinMartinov VenelinMartinov requested a review from t0yv0 October 18, 2023 11:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #1453 (a9cc992) into master (1143155) will decrease coverage by 4.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
- Coverage   61.89%   57.88%   -4.01%     
==========================================
  Files         183      283     +100     
  Lines       32738    39562    +6824     
==========================================
+ Hits        20263    22901    +2638     
- Misses      11335    15323    +3988     
- Partials     1140     1338     +198     
Files Coverage Δ
pkg/tfgen/docs.go 73.04% <100.00%> (+0.09%) ⬆️
pkg/tfgen/metrics.go 100.00% <100.00%> (ø)

... and 103 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@t0yv0
Copy link
Member

t0yv0 commented Oct 18, 2023

This works, actually! Could we try an alternate route where we print out the short summary from the coverage tracker? I think that's the one people wanted to see. Thanks a ton.

@VenelinMartinov
Copy link
Contributor Author

Invalidated by #1456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants