Rollout DiffStrategy=PlanState across providers #866
Comments
|
maybe explicity try gcp/azure as step 3/4 (try, plan) before aws?
i'm not really trying to add "more steps" however, *if* you think the risk
is large, this might be another baby step to consider, since aws really is
the biggest customer risk
…On Mon, Mar 6, 2023 at 9:19 AM Anton Tayanovskyy ***@***.***> wrote:
The improved Diff implementation is under a feature flag DiffStrategy to
make it easier to roll out across Pulumi providers gradually while
mitigating any unexpected consequences. The plan is:
- DiffStrategy=TryPlanState on 5 ecosystem providers
- DiffStrategy=PlanState on 5 ecosystem providers
- DiffStrategy=TryPlanState on pulumi-aws
- DiffStrategy=PlanState on pulumi-aws
- pulumi-aws removes the workaround apply to make pulumi/pulumi-aws#791
<#791> work
for the end-users, namely hashicorp/terraform-provider-aws#25708
<hashicorp/terraform-provider-aws#25708>
reintroduced into forked pulumi-aws upstream and pulumi-aws rebuilt with
unmodified upstream
- DiffStrategy=PlanState by default, remove the flag
—
Reply to this email directly, view it on GitHub
<#866>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB77TQR4W2QCA74MM6YH2PDW2YMATANCNFSM6AAAAAAVRM4E3M>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Great idea, I'll ask again in the providers team channel to confirm. --A
On Mon, Mar 6, 2023 at 12:26 PM Eric Rudder ***@***.***>
wrote:
… maybe explicity try gcp/azure as step 3/4 (try, plan) before aws?
i'm not really trying to add "more steps" however, *if* you think the risk
is large, this might be another baby step to consider, since aws really is
the biggest customer risk
On Mon, Mar 6, 2023 at 9:19 AM Anton Tayanovskyy ***@***.***>
wrote:
> The improved Diff implementation is under a feature flag DiffStrategy to
> make it easier to roll out across Pulumi providers gradually while
> mitigating any unexpected consequences. The plan is:
>
> - DiffStrategy=TryPlanState on 5 ecosystem providers
> - DiffStrategy=PlanState on 5 ecosystem providers
> - DiffStrategy=TryPlanState on pulumi-aws
> - DiffStrategy=PlanState on pulumi-aws
> - pulumi-aws removes the workaround apply to make pulumi/pulumi-aws#791
> <#791> work
> for the end-users, namely hashicorp/terraform-provider-aws#25708
> <hashicorp/terraform-provider-aws#25708>
> reintroduced into forked pulumi-aws upstream and pulumi-aws rebuilt with
> unmodified upstream
> - DiffStrategy=PlanState by default, remove the flag
>
> —
> Reply to this email directly, view it on GitHub
> <#866>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AB77TQR4W2QCA74MM6YH2PDW2YMATANCNFSM6AAAAAAVRM4E3M
>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#866 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANZASIZ4XCOX5E75TKO5LW2YM25ANCNFSM6AAAAAAVRM4E3M>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
Check on #1020 possibly related here. |
|
Hello, for my understanding, since @t0yv0 is unassigned, what is the plan for this issue? Currently the |
|
Hi @marco-m thanks for your feedback, I'm going to prioritize unblocking hcloud specifically given the high impact there. For the remainder of the rollout we will be reconsidering this for Q3. |
|
@t0yv0 thanks, greatly appreciated! |
This change is aimed at fixing pulumi/pulumi-hcloud#175 This provider is early in adopting a feature-flagged change in #866 and uncovered an issue. Due to technicalities this project is linking code from TF plugins and TF CLI proper. The codebases do not agree on the dependency "github.com/hashicorp/go-cty/cty" vs "github.com/zclconf/go-cty/cty/json", necessitating adapter code. There is a bug being fixed here in the adapter code that converts cty.Value objects across these two packages. --------- Co-authored-by: Ian Wahbe <[email protected]>
|
@t0yv0 my first quick tests with |
|
Awesome, great to hear. Thanks for getting back so quickly. |
|
Noting that pulumi-aws v6.0-alpha is coming out with the flag turned on. |
|
Closing in favor of #1785 - this provides a yet-closer-to-TF implementation that started rolling out to fix critical issues, and is the best way forward. |
|
Cannot close issue:
Please fix these problems and try again. |
Internal Design Doc
The improved Diff implementation is under a feature flag DiffStrategy to make it easier to roll out across Pulumi providers gradually while mitigating any unexpected consequences. The specific risk with the new Diff implementation is that it's a sensitive method. For example, it that it might introduce unexpected replace plans to existing infrastructure on provider upgrades. The plan is:
updatewith everypulumi uppulumi-hcloud#170pulumi-aws5.22.0 and above keep updatingaws:route53/resolverEndpoint:ResolverEndpointeven when there's nothing to update #791 work for the end-users, namely b/aws_route53_resolver_endpoint hashicorp/terraform-provider-aws#25708 reintroduced into forked pulumi-aws upstream and pulumi-aws rebuilt with unmodified upstreamThe text was updated successfully, but these errors were encountered: