Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRC issue with detailed diff with unknown element in a set #2427

Closed
VenelinMartinov opened this issue Sep 19, 2024 · 2 comments · Fixed by #2405
Closed

PRC issue with detailed diff with unknown element in a set #2427

VenelinMartinov opened this issue Sep 19, 2024 · 2 comments · Fixed by #2405
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

Under PRC we fail to display a sensible detailed diff when a set contains an unknown element:

Previewing update (test):
  pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:test::test::pulumi:pulumi:Stack::test-test]
    + prov:index/aux:Aux: (create)
        [urn=urn:pulumi:test::test::prov:index/aux:Aux::auxRes]
    ~ prov:index/test:Test: (update)
        [id=newid]
        [urn=urn:pulumi:test::test::prov:index/test:Test::mainRes]
    --outputs:--
  + testOut: output<string>
Resources:
    + 1 to create
    ~ 1 to update
    2 changes. 1 unchanged

vs

Previewing update (test):
  pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:test::test::pulumi:pulumi:Stack::test-test]
    + prov:index/aux:Aux: (create)
        [urn=urn:pulumi:test::test::prov:index/aux:Aux::auxRes]
    ~ prov:index/test:Test: (update)
        [id=newid]
        [urn=urn:pulumi:test::test::prov:index/test:Test::mainRes]
      + tests: [
      +     [0]: output<string>
        ]
    --outputs:--
  + testOut: output<string>
Resources:
    + 1 to create
    ~ 1 to update
    2 changes. 1 unchanged

Example

TestUnknownSetElementDiff/PRC_enabled

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team and removed needs-triage Needs attention from the triage team labels Sep 19, 2024
@t0yv0
Copy link
Member

t0yv0 commented Sep 19, 2024

Looks like this regressed but feels mostly cosmetic. I wonder what the baseline TF behavior is for these cases. We can clean htis up as part of the accurate previews epic thank you.

@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2405 and shipped in release v3.92.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
3 participants