Enable PRC by default #2380
Merged
Enable PRC by default #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
changed the base branch from
master
to
vvm/collection_only_detailed_diff_cross_test
6 tasks
VenelinMartinov
commented
Sep 17, 2024
VenelinMartinov
requested review from
t0yv0,
guineveresaenger,
iwahbe and
a team
t0yv0
reviewed
Sep 18, 2024
t0yv0
reviewed
Sep 18, 2024
|
Thanks for cleaning up the test suite! Mostly looking good, I had a few questions on the removed tests. |
t0yv0
reviewed
Sep 19, 2024
pkg/tests/schema_pulumi_test.go
Outdated
| } | ||
|
|
||
| t.Run("PRC enabled", func(t *testing.T) { | ||
| // TODO[pulumi/pulumi-terraform-bridge#2428]: Incorrect detailed diff with unknown elements |
t0yv0
reviewed
Sep 19, 2024
|
This PR has been shipped in release v3.91.0. |
VenelinMartinov
added a commit
that referenced
this pull request
Sep 20, 2024
Adds a `DiffEqualDecisionOverride` to the shim layer which allows provider implementations to specify a diff decision instead of relying on the shim layer to do that. Also adds a `DiffEqualDecisionOverride` to the PRC sdkv2 implementation which opentofu does. Also adds a feature flag `EnableAccurateBridgePreview` which guards this feature. will fix once rolled out: #2293 will fix once rolled out: #1501 will undo once rolled out: #1502 as the underlying issue was fixed during the PRC work. Stacked on #2380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables PlanResourceChange by default in the bridge. A bunch of tests had to be fixed up to work with PRC.
fixes #1785