Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix previewFeaturesEnabled (from previewFeaturesEnableds) #804

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix previewFeaturesEnabled (from previewFeaturesEnableds) #804

merged 1 commit into from
Jan 13, 2025

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 10, 2025

Fixes #800

@iwahbe iwahbe requested a review from a team January 10, 2025 15:31
@iwahbe iwahbe self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe force-pushed the iwahbe/fix-preview-features-enable-config-name branch from 8b3e3c1 to 4f29941 Compare January 10, 2025 15:35
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (aeb5e4e) to head (4f29941).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
provider/resources.go 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master    #804   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         174     165    -9     
======================================
+ Misses        174     165    -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

t0yv0
t0yv0 reviewed Jan 10, 2025
View reviewed changes
provider/resources.go
},
// Fix pluralization.
//
// Previously was "previewFeaturesEnableds".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof.

@iwahbe iwahbe added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Jan 13, 2025
@iwahbe iwahbe merged commit cd106c9 into master Jan 13, 2025
25 checks passed
@iwahbe iwahbe deleted the iwahbe/fix-preview-features-enable-config-name branch January 13, 2025 11:14
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v1.1.0.

@pulumi-bot pulumi-bot mentioned this pull request Jan 13, 2025
Closed
@github-actions github-actions bot removed the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger guineveresaenger approved these changes

@t0yv0 t0yv0 t0yv0 approved these changes

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulumi-terraform-bridge has generated preview_features_enableds instead of preview_features_enabled
4 participants
@iwahbe @pulumi-bot @t0yv0 @guineveresaenger