This repository has been archived by the owner on May 1, 2024. It is now read-only.
Declare SymbolConstructor for older versions of ES
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
approved these changes
Jun 2, 2019
There was a problem hiding this comment.
LGTM (see pulumi/pulumi#2630 (comment)).
Related follow-up: I noticed this library is now targeting es5 and is setting downlevelIteration to true...
pulumi-query/nodejs/query/tsconfig.json
Line 17 in 58c4156
I think this library should be targeting es6 with downlevelIteration flag removed. All versions of Node.js we support works with es6, all our other Node.js libraries target es6, the default ts-node config for TypeScript projects targets es6, and our TypeScript templates target es6 by default.
Older versions of the ES standard do not define `Symbol#asyncIterator`. This means our attempts to "manually" define `AsyncIterator` for versions of ES that don't have it fail. Following [1] and [2], our understanding is that the best existing solution is to manually re-define `SymbolConstructor` to have this member. [1]: microsoft/TypeScript#13031 [2]: microsoft/TypeScript#8099
hausdorff
force-pushed
the
hausdorff/declare-symbol
branch
from
4331ea8
to
75ec900
Compare
|
@justinvp I meant for this to be also useful to non-Pulumi people, but we can bump to es6 and wait for people to ask for something else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of the ES standard do not define
Symbol#asyncIterator.This means our attempts to "manually" define
AsyncIteratorforversions of ES that don't have it fail.
Following 1 and 2, our understanding is that the best existing
solution is to manually re-define
SymbolConstructorto have thismember.